Skip to content

chore: performance tests for ESDK-python #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jun 5, 2024
Merged

Conversation

RitvikKapila
Copy link
Contributor

Issue #, if available:

Description of changes:
Performance tests for ESDK-python for comparison between keyrings and master key providers based on execution time and memory used.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@RitvikKapila RitvikKapila requested a review from a team as a code owner May 17, 2024 19:31
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your plan for running this in CI?
I wonder if you can put this in GHA...

@RitvikKapila
Copy link
Contributor Author

What's your plan for running this in CI? I wonder if you can put this in GHA...

Currently for CI, I'm thinking of putting this in CodeBuild for consistency with other tests using MPL.

return click.testing.CliRunner()


def test_create(runner):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[curious] how much work would it be to print out the summary statistics to the codebuild logs?

Copy link
Contributor Author

@RitvikKapila RitvikKapila Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would be calling the consolidate results script.
It would basically mean running the consolidate_results.py script from the test python files for each of the tests.

@RitvikKapila RitvikKapila merged commit ebbc26b into mpl-reviewed Jun 5, 2024
147 checks passed
@RitvikKapila RitvikKapila deleted the perf-tests branch June 5, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants